From 2e6ec7a533ef3a4469ccdee42df204da4510aeba Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Magalh=C3=A3es?= <joamag@gmail.com> Date: Sat, 7 Sep 2024 18:37:35 +0100 Subject: [PATCH] fix: some clippy issues --- src/inst.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/inst.rs b/src/inst.rs index 20a11e77..5b2599c3 100644 --- a/src/inst.rs +++ b/src/inst.rs @@ -3150,7 +3150,7 @@ fn rl(cpu: &mut Cpu, value: u8) -> u8 { fn rlc(cpu: &mut Cpu, value: u8) -> u8 { cpu.set_carry((value & 0x80) == 0x80); - let result = (value << 1) | (value >> 7); + let result = value.rotate_left(1); cpu.set_sub(false); cpu.set_zero(result == 0); @@ -3179,7 +3179,7 @@ fn rr(cpu: &mut Cpu, value: u8) -> u8 { fn rrc(cpu: &mut Cpu, value: u8) -> u8 { cpu.set_carry((value & 0x1) == 0x1); - let result = (value >> 1) | (value << 7); + let result = value.rotate_right(1); cpu.set_sub(false); cpu.set_zero(result == 0); @@ -3323,7 +3323,7 @@ fn swap(cpu: &mut Cpu, value: u8) -> u8 { cpu.set_half_carry(false); cpu.set_carry(false); - (value << 4) | (value >> 4) + value.rotate_right(4) } /// Helper function to shift an `u8` to the left and update CPU -- GitLab