diff --git a/CHANGELOG.md b/CHANGELOG.md index bbcc71bbc4b239fee0a1d053d3adfa810e868798..3aff5a9cb75e3f44d0246cd98da78541cb3822d1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -17,7 +17,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Fixed -* +* Arrow keys usage for on-screen gamepad ## [0.4.1] - 2022-11-06 diff --git a/examples/web/index.ts b/examples/web/index.ts index 4da7b07c62f02fba865a0bfefc4571d69d126b6e..5daac83a0ab9288c55f88a72055f2ffd656671a3 100644 --- a/examples/web/index.ts +++ b/examples/web/index.ts @@ -483,13 +483,13 @@ class GameboyEmulator extends EmulatorBase implements Emulator { keyPress(key: string) { const keyCode = KEYS_NAME[key]; - if (!keyCode) return; + if (keyCode === undefined) return; this.gameBoy!.key_press(keyCode); } keyLift(key: string) { const keyCode = KEYS_NAME[key]; - if (!keyCode) return; + if (keyCode === undefined) return; this.gameBoy!.key_lift(keyCode); } diff --git a/examples/web/react/app.tsx b/examples/web/react/app.tsx index 4111def049b5b342346e685e55fc172ae2103c55..ad01897b2abce06c63cb7597a93fab38b216e681 100644 --- a/examples/web/react/app.tsx +++ b/examples/web/react/app.tsx @@ -431,7 +431,6 @@ export const App: FC<AppProps> = ({ emulator, backgrounds = ["264653"] }) => { setFullscreen(!fullscreen); }; const onKeyDown = (key: string) => { - console.info(key); emulator.keyPress(key); }; const onKeyUp = (key: string) => { diff --git a/examples/web/react/components/keyboard-gb/keyboard-gb.tsx b/examples/web/react/components/keyboard-gb/keyboard-gb.tsx index dddeaa6c9ffb28c1e5f61d8c2f9b3033db425159..f1e4816bbb1b1ffa51862e07196de7403bd04902 100644 --- a/examples/web/react/components/keyboard-gb/keyboard-gb.tsx +++ b/examples/web/react/components/keyboard-gb/keyboard-gb.tsx @@ -72,14 +72,14 @@ export const KeyboardGB: FC<KeyboardGBProps> = ({ > <div className="dpad"> <div className="dpad-top"> - {renderKey("🡑", "ArrowUp", ["up"])} + {renderKey("â–²", "ArrowUp", ["up"])} </div> <div> - {renderKey("ðŸ¡", "ArrowLeft", ["left"])} - {renderKey("🡒", "ArrowRight", ["right"])} + {renderKey("â—„", "ArrowLeft", ["left"])} + {renderKey("â–º", "ArrowRight", ["right"])} </div> <div className="dpad-bottom"> - {renderKey("🡓", "ArrowDown", ["down"])} + {renderKey("â–¼", "ArrowDown", ["down"])} </div> </div> <div className="action">