From 31de4c107693d674b62ff6c9617b550d7bfed49c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jo=C3=A3o=20Magalh=C3=A3es?= <joamag@gmail.com>
Date: Sun, 6 Nov 2022 12:23:32 +0000
Subject: [PATCH] fix: arrow keys usage for on-screen gamepad

---
 CHANGELOG.md                                              | 2 +-
 examples/web/index.ts                                     | 4 ++--
 examples/web/react/app.tsx                                | 1 -
 examples/web/react/components/keyboard-gb/keyboard-gb.tsx | 8 ++++----
 4 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index bbcc71bb..3aff5a9c 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -17,7 +17,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 
-*
+* Arrow keys usage for on-screen gamepad
 
 ## [0.4.1] - 2022-11-06
 
diff --git a/examples/web/index.ts b/examples/web/index.ts
index 4da7b07c..5daac83a 100644
--- a/examples/web/index.ts
+++ b/examples/web/index.ts
@@ -483,13 +483,13 @@ class GameboyEmulator extends EmulatorBase implements Emulator {
 
     keyPress(key: string) {
         const keyCode = KEYS_NAME[key];
-        if (!keyCode) return;
+        if (keyCode === undefined) return;
         this.gameBoy!.key_press(keyCode);
     }
 
     keyLift(key: string) {
         const keyCode = KEYS_NAME[key];
-        if (!keyCode) return;
+        if (keyCode === undefined) return;
         this.gameBoy!.key_lift(keyCode);
     }
 
diff --git a/examples/web/react/app.tsx b/examples/web/react/app.tsx
index 4111def0..ad01897b 100644
--- a/examples/web/react/app.tsx
+++ b/examples/web/react/app.tsx
@@ -431,7 +431,6 @@ export const App: FC<AppProps> = ({ emulator, backgrounds = ["264653"] }) => {
         setFullscreen(!fullscreen);
     };
     const onKeyDown = (key: string) => {
-        console.info(key);
         emulator.keyPress(key);
     };
     const onKeyUp = (key: string) => {
diff --git a/examples/web/react/components/keyboard-gb/keyboard-gb.tsx b/examples/web/react/components/keyboard-gb/keyboard-gb.tsx
index dddeaa6c..f1e4816b 100644
--- a/examples/web/react/components/keyboard-gb/keyboard-gb.tsx
+++ b/examples/web/react/components/keyboard-gb/keyboard-gb.tsx
@@ -72,14 +72,14 @@ export const KeyboardGB: FC<KeyboardGBProps> = ({
         >
             <div className="dpad">
                 <div className="dpad-top">
-                    {renderKey("🡑", "ArrowUp", ["up"])}
+                    {renderKey("â–²", "ArrowUp", ["up"])}
                 </div>
                 <div>
-                    {renderKey("🡐", "ArrowLeft", ["left"])}
-                    {renderKey("🡒", "ArrowRight", ["right"])}
+                    {renderKey("â—„", "ArrowLeft", ["left"])}
+                    {renderKey("â–º", "ArrowRight", ["right"])}
                 </div>
                 <div className="dpad-bottom">
-                    {renderKey("🡓", "ArrowDown", ["down"])}
+                    {renderKey("â–¼", "ArrowDown", ["down"])}
                 </div>
             </div>
             <div className="action">
-- 
GitLab