From 411dfa100aad958b06c794444a362268bbfc7f93 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jo=C3=A3o=20Magalh=C3=A3es?= <joamag@gmail.com>
Date: Sun, 10 Jul 2022 22:16:43 +0100
Subject: [PATCH] fix: unimplemented MBC1 error
---
src/rom.rs | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/rom.rs b/src/rom.rs
index 78ab8e64..e05b6386 100644
--- a/src/rom.rs
+++ b/src/rom.rs
@@ -443,7 +443,9 @@ pub static MBC1: Mbc = Mbc {
}
// ROM mode selection
0x6000 | 0x7000 => {
- unimplemented!("ROM mode selection for MBC1 is not implemented");
+ if value == 0x1 && rom.rom_bank_count > 32 {
+ unimplemented!("Advanced ROM banking mode for MBC1 is not implemented");
+ }
}
_ => panic!("Writing to unknown Cartridge ROM location 0x{:04x}", addr),
}
--
GitLab