From 9d97e26d6f730c84b0be45de0a46fc000cca1f9d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jo=C3=A3o=20Magalh=C3=A3es?= <joamag@gmail.com>
Date: Tue, 6 Jun 2023 19:19:37 +0100
Subject: [PATCH] fix: clippy issues
---
src/cpu.rs | 2 +-
src/dma.rs | 6 +++---
src/mmu.rs | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/cpu.rs b/src/cpu.rs
index ec512278..fad2c356 100644
--- a/src/cpu.rs
+++ b/src/cpu.rs
@@ -582,7 +582,7 @@ impl Cpu {
impl Default for Cpu {
fn default() -> Self {
let gbc: Rc<RefCell<GameBoyConfig>> = Rc::new(RefCell::new(GameBoyConfig::default()));
- Cpu::new(Mmu::default(), gbc.clone())
+ Cpu::new(Mmu::default(), gbc)
}
}
diff --git a/src/dma.rs b/src/dma.rs
index 13e243f1..9e048b59 100644
--- a/src/dma.rs
+++ b/src/dma.rs
@@ -124,7 +124,7 @@ mod tests {
#[test]
fn test_dma_default() {
let dma = Dma::default();
- assert_eq!(dma.active, false);
+ assert!(!dma.active);
}
#[test]
@@ -142,13 +142,13 @@ mod tests {
assert_eq!(dma.destination, 0x0);
assert_eq!(dma.length, 0x0);
assert_eq!(dma.mode, DmaMode::General);
- assert_eq!(dma.active, false);
+ assert!(!dma.active);
}
#[test]
fn test_dma_set_active() {
let mut dma = Dma::new();
dma.set_active(true);
- assert_eq!(dma.active, true);
+ assert!(dma.active);
}
}
diff --git a/src/mmu.rs b/src/mmu.rs
index bdcecbf6..a32bbe8b 100644
--- a/src/mmu.rs
+++ b/src/mmu.rs
@@ -538,6 +538,6 @@ impl Default for Mmu {
timer: Timer::default(),
serial: Serial::default(),
};
- Mmu::new(components, mode, gbc.clone())
+ Mmu::new(components, mode, gbc)
}
}
--
GitLab