From bde3b43cc95f8dfe982e832dc3db33b6bb992224 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jo=C3=A3o=20Magalh=C3=A3es?= <joamag@gmail.com>
Date: Mon, 14 Nov 2022 20:20:41 +0000
Subject: [PATCH] refactor: new supported pads values
---
.../react/components/keyboard-gb/keyboard-gb.tsx | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/examples/web/react/components/keyboard-gb/keyboard-gb.tsx b/examples/web/react/components/keyboard-gb/keyboard-gb.tsx
index 70af7a2a..5e3368dd 100644
--- a/examples/web/react/components/keyboard-gb/keyboard-gb.tsx
+++ b/examples/web/react/components/keyboard-gb/keyboard-gb.tsx
@@ -52,6 +52,12 @@ type KeyboardGBProps = {
onGamepad?: (id: string, isValid: boolean, connected?: boolean) => void;
};
+/**
+ * The sequence of game pads that are considered
+ * supported by the current implementation.
+ */
+const SUPPORTED_PADS = [Gamepad.Xbox];
+
export const KeyboardGB: FC<KeyboardGBProps> = ({
focusable = true,
fullscreen = false,
@@ -108,7 +114,7 @@ export const KeyboardGB: FC<KeyboardGBProps> = ({
const onGamepadConnected = (event: GamepadEvent) => {
const gamepad = event.gamepad;
let gamepadType = getGamepadType(gamepad);
- const isValid = [Gamepad.Xbox].includes(gamepadType);
+ const isValid = SUPPORTED_PADS.includes(gamepadType);
onGamepad && onGamepad(gamepad.id, isValid);
@@ -153,12 +159,9 @@ export const KeyboardGB: FC<KeyboardGBProps> = ({
};
const onGamepadDisconnected = (event: GamepadEvent) => {
const gamepad = event.gamepad;
- let gamepadType = Gamepad.Unknown;
-
- const isXbox = gamepad.id.startsWith("Xbox");
- if (isXbox) gamepadType = Gamepad.Xbox;
+ let gamepadType = getGamepadType(gamepad);
+ const isValid = SUPPORTED_PADS.includes(gamepadType);
- const isValid = [Gamepad.Xbox].includes(gamepadType);
onGamepad && onGamepad(gamepad.id, isValid, false);
};
document.addEventListener("keydown", _onKeyDown);
--
GitLab