From f3984ed79a745c61514c8973a91fff9a501a4706 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jo=C3=A3o=20Magalh=C3=A3es?= <joamag@gmail.com>
Date: Tue, 1 Nov 2022 11:08:14 +0000
Subject: [PATCH] refactor: simplified code
---
.../react/components/button-increment/button-increment.tsx | 5 +----
examples/web/react/components/button/button.tsx | 6 +++---
2 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/examples/web/react/components/button-increment/button-increment.tsx b/examples/web/react/components/button-increment/button-increment.tsx
index a4395b77..ecd2aebb 100644
--- a/examples/web/react/components/button-increment/button-increment.tsx
+++ b/examples/web/react/components/button-increment/button-increment.tsx
@@ -32,9 +32,6 @@ export const ButtonIncrement: FC<ButtonIncrementProps> = ({
}) => {
const [valueState, setValue] = useState(value);
const classes = () => ["button-increment", size, ...style].join(" ");
- const _onClick = () => {
- if (onClick) onClick();
- };
const _onMinusClick = () => {
const valueNew = valueState - delta;
if (onBeforeChange) {
@@ -54,7 +51,7 @@ export const ButtonIncrement: FC<ButtonIncrementProps> = ({
if (onChange) onChange(valueNew);
};
return (
- <span className={classes()} onClick={_onClick}>
+ <span className={classes()} onClick={onClick}>
<Button
text={"-"}
size={size}
diff --git a/examples/web/react/components/button/button.tsx b/examples/web/react/components/button/button.tsx
index 9f7e9ea7..c16ae02e 100644
--- a/examples/web/react/components/button/button.tsx
+++ b/examples/web/react/components/button/button.tsx
@@ -35,12 +35,12 @@ export const Button: FC<ButtonProps> = ({
onFile && onFile(file);
event.target.value = "";
};
- const renderButtonSimple = () => (
+ const renderSimple = () => (
<span className={classes()} onClick={onClick}>
{text}
</span>
);
- const renderButtonComplex = () => (
+ const renderComplex = () => (
<span className={classes()} onClick={onClick}>
{image && <img src={image} alt={imageAlt || text || "button"} />}
{file && (
@@ -49,7 +49,7 @@ export const Button: FC<ButtonProps> = ({
<span>{text}</span>
</span>
);
- return image ? renderButtonComplex() : renderButtonSimple();
+ return image ? renderComplex() : renderSimple();
};
export default Button;
--
GitLab