Skip to content
Snippets Groups Projects
Verified Commit 69062de0 authored by João Magalhães's avatar João Magalhães :rocket:
Browse files

docs: added SameBoy references for improvements

parent 24f29500
No related branches found
No related tags found
1 merge request!31System state save
Pipeline #3271 passed
...@@ -772,6 +772,9 @@ impl State for BeesCore { ...@@ -772,6 +772,9 @@ impl State for BeesCore {
u8::from(gb.cpu().halted()), u8::from(gb.cpu().halted()),
// @TODO: these registers cannot be totally retrieved // @TODO: these registers cannot be totally retrieved
// because of that some audio noise exists // because of that some audio noise exists
// The loading of the registers should be done in a much
// more manual way like SameBoy does here
// https://github.com/LIJI32/SameBoy/blob/7e6f1f866e89430adaa6be839aecc4a2ccabd69c/Core/save_state.c#L673
gb.mmu().read_many(0xff00, 128).try_into().unwrap(), gb.mmu().read_many(0xff00, 128).try_into().unwrap(),
); );
core.ram.fill_buffer(gb.mmu().ram()); core.ram.fill_buffer(gb.mmu().ram());
...@@ -802,6 +805,9 @@ impl State for BeesCore { ...@@ -802,6 +805,9 @@ impl State for BeesCore {
// @TODO: we need to be careful about this writing and // @TODO: we need to be careful about this writing and
// should make this a bit more robust, to handle this // should make this a bit more robust, to handle this
// special case/situations // special case/situations
// The registers should be handled in a more manual manner
// to avoid unwanted side effects
// https://github.com/LIJI32/SameBoy/blob/7e6f1f866e89430adaa6be839aecc4a2ccabd69c/Core/save_state.c#L1003
gb.mmu().write_many(0xff00, &self.io_registers); gb.mmu().write_many(0xff00, &self.io_registers);
gb.mmu().set_ram(self.ram.buffer.to_vec()); gb.mmu().set_ram(self.ram.buffer.to_vec());
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment