Skip to content
Snippets Groups Projects
Verified Commit a6e5b7f2 authored by João Magalhães's avatar João Magalhães :rocket:
Browse files

chore: small perf improvement using useCallback

parent 65815c2c
No related branches found
No related tags found
No related merge requests found
Pipeline #4995 passed
import React, { FC, useEffect, useState } from "react"; import React, { FC, useCallback, useEffect, useState } from "react";
import { ButtonSwitch, Info, Pair } from "emukit"; import { ButtonSwitch, Info, Pair } from "emukit";
import { AudioGB } from "../audio-gb/audio-gb"; import { AudioGB } from "../audio-gb/audio-gb";
import { RegistersGB } from "../registers-gb/registers-gb"; import { RegistersGB } from "../registers-gb/registers-gb";
...@@ -92,25 +92,36 @@ const DebugSettingsContent: FC<EmulatorProps> = ({ emulator }) => { ...@@ -92,25 +92,36 @@ const DebugSettingsContent: FC<EmulatorProps> = ({ emulator }) => {
}; };
}, [emulator]); }, [emulator]);
const onPpuChange = (option: string) => { const onPpuChange = useCallback(
emulator.instance?.set_ppu_enabled(option === "on"); (option: string) => {
}; emulator.instance?.set_ppu_enabled(option === "on");
},
const onApuChange = (option: string) => { [emulator]
emulator.instance?.set_apu_enabled(option === "on"); );
}; const onApuChange = useCallback(
(option: string) => {
const onDmaChange = (option: string) => { emulator.instance?.set_apu_enabled(option === "on");
emulator.instance?.set_dma_enabled(option === "on"); },
}; [emulator]
);
const onTimerChange = (option: string) => { const onDmaChange = useCallback(
emulator.instance?.set_timer_enabled(option === "on"); (option: string) => {
}; emulator.instance?.set_dma_enabled(option === "on");
},
const onSerialChange = (option: string) => { [emulator]
emulator.instance?.set_serial_enabled(option === "on"); );
}; const onTimerChange = useCallback(
(option: string) => {
emulator.instance?.set_timer_enabled(option === "on");
},
[emulator]
);
const onSerialChange = useCallback(
(option: string) => {
emulator.instance?.set_serial_enabled(option === "on");
},
[emulator]
);
return ( return (
<Info key={updated}> <Info key={updated}>
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment